Add dist git branch to testing farm context #2936
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the dist-git-branch to the Testing Farm context for downstream jobs, which is a useful addition for test environment context. The implementation is correct, and a new unit test has been added to verify the change. I've made one minor suggestion in the test file to combine multiple import statements from the same module for better code style and readability. Overall, great work!
| from packit_service.worker.helpers.testing_farm import ( | ||
| DownstreamTestingFarmJobHelper, | ||
| ) | ||
| from packit_service.worker.helpers.testing_farm import ( | ||
| TestingFarmClient as TFClient, | ||
| ) |
There was a problem hiding this comment.
To improve readability and adhere to Python's style guidelines (PEP 8), it's better to combine multiple imports from the same module into a single statement.
from packit_service.worker.helpers.testing_farm import (
DownstreamTestingFarmJobHelper,
TestingFarmClient as TFClient,
)
|
✔️ pre-commit SUCCESS in 1m 43s |
| "tmt": { | ||
| "context": { | ||
| "distro": distro, | ||
| "dist-git-branch": self.koji_build.target, |
There was a problem hiding this comment.
target isn't always equal to branch name. There can be a eln build from the rawhide branch (and other cases, but those shouldn't really be initiated by Packit, so we can ignore them).
There was a problem hiding this comment.
Oh, thanks. Will try to find a better approach.
There was a problem hiding this comment.
I've just noticed there is an alternative solution - #2935 . Is this appproach correct?
2 participants
Fixes: #2924